8000 getState() in actionCreators returns initial state, not current state after a reload · Issue #90 · reduxjs/redux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

getState() in actionCreators returns initial state, not current state after a reload #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aaronjensen opened this issue Jun 14, 2015 · 5 comments · Fixed by #92
Closed

getState() in actionCreators returns initial state, not current state after a reload #90

aaronjensen opened this issue Jun 14, 2015 · 5 comments · Fixed by #92

Comments

@aaronjensen
Copy link
Contributor

In the example app, incrementIfOdd breaks after the first hot reload. getState seems to return the initial state rather than the current state.
@gaearon
Copy link
Contributor
gaearon commented Jun 14, 2015

Good catch, I can reproduce this.

@gaearon
Copy link
Contributor
gaearon commented Jun 14, 2015

If you'd like to add a failing test for this, I would appreciate it!

@aaronjensen
Copy link
Contributor Author

after looking at it briefly, i'm not sure of how to write a test for it. It looks like a new Redux is getting created with a new initialState on hot reload, it's not getting the current state from the old Redux. I'm still getting my bearings though so that could be wrong...

@gaearon
Copy link
Contributor
gaearon commented Jun 14, 2015

The test would create two Redux instances, call redux.replaceDispatcher(nextRedux.getDispatcher()), then fire an action and verify that callback-form action creators still receive the most recent state.

@gaearon
Copy link
Contributor
gaearon commented Jun 14, 2015

I'm currently looking at the underlying problem, but a test would help make sure I actually fix it correctly. :-)

aaronjensen added a commit to aaronjensen/redux that referenced this issue Jun 14, 2015
@aaronjensen
Add failing test for reduxjs#90
96313a7
@aaronjensen aaronjensen mentioned this issue Jun 14, 2015
Merged
gaearon added a commit that referenced this issue Jun 14, 2015
@gaearon
Change middleware signature to fix stale getState reference (#90)
24081c6
gaearon added a commit that referenced this issue Jun 14, 2015
@gaearon
Fix stale getState on hot reloading (#90)
830039e
gaearon added a commit that referenced this issue Jun 14, 2015
@gaearon
Fix stale getState on hot reloading (#90)
4acf88a
@gaearon gaearon mentioned this issue Jun 14, 2015
Merged
This was referenced Sep 24, 2020
Open
Open
This was referenced Jan 18, 2022
Open
Open
@rolandhack rolandhack mentioned this issue Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stale state inside action creators on hot reload reduxjs/redux
2 participants
@aaronjensen @gaearon
0