8000 Use Rails::Application#secret_key_base first by JunichiIto · Pull Request #610 · refile/refile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use Rails::Application#secret_key_base first #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Rails::Application#secret_key_base first #610

wants to merge 1 commit into from

Conversation

JunichiIto
Copy link

Current implementation will raise error even if ENV["SECRET_KEY_BASE"] is set. This PR make it work by using Rails::Application#secret_key_base.

See also https://api.rubyonrails.org/classes/Rails/Application.html#method-i-secret_key_base

Maybe related to #596

Here is the results in my sample app deployed to Heroku:

irb(main):001:0> Rails.application.secret_key_base
=> "3b280b2ea435b3768039021b09e0362c9bafa76adf4606b121de4f28ecc630e5002acc05ce5797c3a525722cc6d5cc1408c5e24dc3ba76e27ffd7fa68eb7e7d9"
irb(main):002:0> Refile.secret_key
=> "3b280b2ea435b3768039021b09e0362c9bafa76adf4606b121de4f28ecc630e5002acc05ce5797c3a525722cc6d5cc1408c5e24dc3ba76e27ffd7fa68eb7e7d9"
irb(main):003:0> ENV["SECRET_KEY_BASE"]
=> "3b280b2ea435b3768039021b09e0362c9bafa76adf4606b121de4f28ecc630e5002acc05ce5797c3a525722cc6d5cc1408c5e24dc3ba76e27ffd7fa68eb7e7d9"

Without this PR, Refile.secret_key will be nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JunichiIto
0