8000 Compatibility to Rails 7.1.x and Ruby 3.3.x by thadeu · Pull Request #619 · refile/refile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Compatibility to Rails 7.1.x and Ruby 3.3.x #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

thadeu
Copy link
@thadeu thadeu commented Jan 28, 2025

Why?

I think that repository was abandoned, the same way I'd created this PR to reforce our dependency to update this repository.

I need to skip some test in the features folder, because i dont know the test was broken.

Related

#615 #612 #614 #618 #617

Tests

image

@@ -39,6 +42,16 @@ class TestApp < Rails::Application
end
end

require 'capybara/poltergeist'
Copy link
@Faq Faq Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually poltergeist is long dead, what the point adding it here?

@@ -4,6 +4,7 @@
require "refile/backend_examples&qu 91E6 ot;
require "webmock/rspec"
require "refile/file_double"
require 'byebug'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0