8000 tag: output the original ID and new snapshotID by konidev20 · Pull Request #5144 · restic/restic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

tag: output the original ID and new snapshotID #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2025
Merged

tag: output the original ID and new snapshotID #5144

merged 4 commits into from
Jan 14, 2025

Conversation

konidev20
Copy link
Contributor
@konidev20 konidev20 commented Nov 16, 2024 •
edited
Loading

What does this PR change? What problem does it solve?

This PR adds the ability of the restic tag command to return the modified snapshot ID when the tag command is run.

Was the change previously discussed in an issue or on the forum?

Closes #5137

Checklist

  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I'm done! This pull request is ready for review.

MichaelEischer
MichaelEischer requested changes Dec 1, 2024
View reviewed changes
@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 3928222 to 222d505 Compare December 14, 2024 20:25
@konidev20 konidev20 marked this pull request as ready for review December 14, 2024 20:37
@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 7bbdd91 to 9a2d3a0 Compare December 15, 2024 06:49
@konidev20 konidev20 force-pushed 8000 the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 5d1cda5 to 02ff018 Compare December 24, 2024 10:20
MichaelEischer
MichaelEischer requested changes Jan 13, 2025
View reviewed changes
Copy link
Member
@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes so far and sorry for the late review. I have a few more small nits.

MichaelEischer
MichaelEischer reviewed Jan 13, 2025
View reviewed changes
@konidev20
tag: output the original ID and new snapshotID
99b6721 
tag: print changed snapshot information immediately

* print changed snapshot immediately after it has been saved
* add message type to the changedSnapshot
* add a summary type which will share the JSON output of the numer of changed snapshots
* updated verbosity of the changed snapshot in text mode to only work when verbosity > 2
* also use the terminal status printer for a standard handling for stdout messages

docs: add json schema for tag command
@konidev20
changelog: add changelog entry for resticgh-5137
db1cebd
@konidev20
tag: rename original_snapshot_id to old_snapshot_id
659f641
@konidev20
tag: rename changed_snapshot_count to changed_snapshots
537a040
@konidev20 konidev20 force-pushed the fix-gh-5137-tags-cmd-output-changed-snapshotID branch from 02ff018 to 537a040 Compare January 14, 2025 14:08
MichaelEischer
MichaelEischer approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member
@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MichaelEischer MichaelEischer merged commit 115ecb3 into restic:master Jan 14, 2025
12 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 27, 2025
Merged
@konidev20 konidev20 mentioned this pull request Apr 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelEischer MichaelEischer MichaelEischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output new snapshot ID whenever the tag command causes an existing ID to change
2 participants
@konidev20 @MichaelEischer
0