8000 cog train: bring functionality on par with cog predict by yorickvP · Pull Request #1391 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cog train: bring functionality on par with cog predict #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

yorickvP
Copy link
Contributor
  • Currently, cog train always writes to weights
  • Currently, there's no way to use it with already existing images
  • Some models have a weights directory

Together, this makes for a terrible experience. This PR adds a way to specify the output directory and use an existing image.

@yorickvP yorickvP force-pushed the yorickvp/weights-outpath branch from 407311b to 882f0be Compare November 20, 2023 17:37
@anotherjesse
Copy link
Contributor

@yorickvP I haven't run this - but the weights are/were base64 datauris inside a json file!

this is extremely painful

@yorickvP yorickvP requested a review from mattt February 8, 2024 15:10
yorickvP added 2 commits July 17, 2024 05:05
Signed-off-by: Yorick van Pelt <yorick@yorickvanpelt.nl>
Signed-off-by: Yorick van Pelt <yorick@yorickvanpelt.nl>
@mattt mattt force-pushed the yorickvp/weights-outpath branch from ce0d99b to 38c96d8 Compare July 17, 2024 12:07
@mattt mattt merged commit 8148407 into main Jul 17, 2024
12 checks passed
@mattt mattt deleted the yorickvp/weights-outpath branch July 17, 2024 12:13
Copy link
Contributor
@mattt mattt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yorickvP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0