8000 fix(test): 'docker' 'rmi' failed in python integration tests by dkhokhlov · Pull Request #1417 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(test): 'docker' 'rmi' failed in python integration tests #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix(test): 'docker' 'rmi' failed in python integration tests #1417

merged 1 commit into from
Dec 7, 2023

Conversation

dkhokhlov
Copy link
Contributor
@dkhokhlov dkhokhlov commented Dec 7, 2023 •
edited
Loading
  • fixes the case when "make test-integration" fails intermittently in test cleanup that removes image
  • added def remove_docker_image(image_name, max_attempts=5, wait_seconds=1):

@dkhokhlov
fix: 'docker' 'rmi' failed in python integration tests
0e800ad 
Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
@dkhokhlov dkhokhlov force-pushed the dmitri/remove_docker_image_in_tests branch from 0ae4f9d to 0e800ad Compare December 7, 2023 22:55
@dkhokhlov dkhokhlov changed the title fix: 'docker' 'rmi' failed in python integration tests fix(test): 'docker' 'rmi' failed in python integration tests Dec 7, 2023
@dkhokhlov dkhokhlov merged commit 1234e81 into main Dec 7, 2023
@dkhokhlov dkhokhlov deleted the dmitri/remove_docker_image_in_tests branch December 7, 2023 23:14
technillogue pushed a commit that referenced this pull request Dec 8, 2023
@dkhokhlov @technillogue
fix(test): 'docker' 'rmi' failed in python integration tests (#1417)
c1c724e 
- fixes the case when "make test-integration" fails intermittently in test cleanup that removes image;
- added def remove_docker_image(image_name, max_attempts=5, wait_seconds=1):;

Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickstenning nickstenning Awaiting requested review from nickstenning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dkhokhlov
0