Don't return a PredictionResponse from PredictionRunner.setup #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
086d20a to
50ea06b
Compare
Returning a PredictionResponse from setup was (I think) a bit of a hack to make the typechecker happy. Unfortunately it's pretty confusing, as PredictionResponse has a whole bunch of fields on it that mean nothing in the context of a setup result. This commit reduces the confusion by introducing a dedicated SetupResult type and using that where appropriate. Signed-off-by: Nick Stenning <nick@whiteink.com>
50ea06b to
0917988
Compare
yorickvP
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning a
PredictionResponsefrom setup was (I think) a bit of a hack to make the typechecker happy. Unfortunately it's pretty confusing, asPredictionResponsehas a whole bunch of fields on it that mean nothing in the context of a setup result.This commit reduces the confusion by introducing a dedicated
SetupResulttype and using that where appropriate.