Validate minor version for CUDA and Python #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user specifies a CUDA or Python version in the cog.yaml, we now ensure that at least the minor version is set. This validation ensures that our compatibility version logic works properly. Additionally, this commit adds logic to the CUDA version selection process, enabling it to pick the latest versions of both CUDA and Ubuntu that satisfy the major.minor constraints. It also fixes a bug in the config parsing that caused a panic if the user defined only the major version of Python. Signed-off-by: Marcus Martins <marcus@replicate.com>
zeke
reviewed
Jun 7, 2024
| @@ -25,13 +25,13 @@ This stanza describes how to build the Docker image your model runs in. It conta | |||
|
|
|||
| ### `cuda` | |||
|
|
|||
| Cog automatically picks the correct version of CUDA to install, but this lets you override it for whatever reason. | |||
| Cog automatically picks the correct version of CUDA to install, but this lets you override it for whatever reason by specifying the minor (`11.8`) or patch (`11.8.0`) version of CUDA to use. | |||
zeke
approved these changes
Jun 7, 2024
Signed-off-by: Marcus Martins <marcus@replicate.com>
mattt
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user specifies a CUDA or Python version in the cog.yaml, we now ensure that at least the minor version is set. This validation ensures that our compatibility version logic works properly.
Additionally, this commit adds logic to the CUDA version selection process, enabling it to pick the latest versions of both CUDA and Ubuntu that satisfy the major.minor constraints.
It also fixes a bug in the config parsing that caused a panic if the user defined only the major version of Python.