8000 [async] Propagate trace context to webhook and upload requests by aron · Pull Request #1787 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[async] Propagate trace context to webhook and upload requests #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2024
Merged

[async] Propagate trace context to webhook and upload requests #1787

merged 1 commit into from
Jul 12, 2024

Conversation

aron
Copy link
Contributor
@aron aron commented Jul 4, 2024

Based on the implementation in #1698.

If the request to /predict contains headers traceparent and tracestate defined by w3c Trace Context1 then these headers are forwarded on to the webhook and upload calls.

This allows observability systems to link requests passing through cog.

Footnotes

  1. https://www.w3.org/TR/trace-context/ ↩

@aron aron changed the base branch from main to async July 4, 2024 17:52
@aron aron requested a review from a team July 4, 2024 17:52
@aron aron changed the title Propagate trace context to webhook and upload requests [async] Propagate trace context to webhook and upload requests Jul 4, 2024
aron
aron commented Jul 4, 2024
View reviewed changes
@aron aron force-pushed the async-add-trace-headers branch 2 times, most recently from 6d91f07 to 695b7c4 Compare July 4, 2024 21:14
technillogue
technillogue reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor
@technillogue technillogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for taking a stab at the tests 🙏

@aron aron force-pushed the async-add-trace-headers branch from 1785487 to a87174b Compare July 11, 2024 10:18 8000
@aron aron requested a review from technillogue July 11, 2024 10:18
@aron aron force-pushed the async-add-trace-headers branch from a87174b to 769759e Compare July 11, 2024 10:24
technillogue
technillogue reviewed Jul 12, 2024
View reviewed changes
@aron @technillogue
Propagate trace context to webhook and upload requests
8f196cb 
Based on the implementation in #1698 for sync cog.

If the request to /predict contains headers `traceparent` and
`tracestate` defined by w3c Trace Context[^1] then these headers are
forwarded on to the webhook and upload calls.

This allows observability systems to link requests passing through cog.

[^1]: https://www.w3.org/TR/trace-context/

Signed-off-by: technillogue <technillogue@gmail.com>
@technillogue technillogue force-pushed the async-add-trace-headers branch from 00ccdb9 to 8f196cb Compare July 12, 2024 22:45
@technillogue technillogue merged commit 5d38ae7 into async Jul 12, 2024
7 of 8 checks passed
@technillogue technillogue deleted the async-add-trace-headers branch July 12, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technillogue technillogue technillogue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aron @technillogue
0