Support torch patch base images #1894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Do not strip patch version from torch
- If the user specifies a torch version without a patch, resolve the highest patch version from our compatibility matrix
- Change the version struct to use a pointer for the patch version in order to handle cases where the pointer has not been supplied (and how that manifests when comparing versions)
- Standardise on StripModifier for the version rendering
- No longer generate a torch minor compatibility matrix, unnecessary now we explicitly define patch version compatibilities
* Support base images based on torch patch versions.
* Do not forward cu118 et al version modifiers
* Make sure the modifier is always stripped from torch (we don’t need it anymore) * Support major/minor versions of torch that resolve to latest patch version * Add the concept of a set Patch to version, that allows logic to know whether the patch version is explicitly set or not.
* When rendering the base image name, resolve the latest torch patch version if not supplied * Add BaseImageConfigurations that conform to the null CUDA
Yeh the next PR after this one handles torchvision and torchaudio |
andreasjansson
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.