10000 Generate optimized python binaries with pyenv by 8W9aG · Pull Request #1900 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Generate optimized python binaries with pyenv #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Generate optimized python binaries with pyenv #1900

merged 1 commit into from
Aug 23, 2024

Conversation

8W9aG
Copy link
Contributor
@8W9aG 8W9aG commented Aug 23, 2024
  • Follow the pyenv guide for producing optimised python binaries for better performance.

https://github.com/pyenv/pyenv/blob/master/plugins/python-build/README.md#building-for-maximum-performance

If the user is not using a base image this adds some latency to the build, I am guessing this might be fine since not supported base images are rare

* Follow the pyenv guide for producing optimised
python binaries for better performance.
Copy link
Contributor
@nickstenning nickstenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this seems fine. I wonder how we'd test this?

More broadly, I do slightly wonder whether we should be switching away from pyenv altogether. uv now supports downloading and installing Python versions from 3.8 upwards. (uv python install 3.8) Should we evaluate that?

@8W9aG
Copy link
Contributor Author
8W9aG commented Aug 23, 2024

Generally this seems fine. I wonder how we'd test this?

More broadly, I do slightly wonder whether we should be switching away from pyenv altogether. uv now supports downloading and installing Python versions from 3.8 upwards. (uv python install 3.8) Should we evaluate that?

Beyond the integration tests we have there probably isn't much we can do testing wise, other than trust that compilers are generally dependable. For what its worth some of the other fixes I've got coming down the pipeline deal with pyenv and I'm not convinced it should be used in a high performance environment, evaluating uv can be done as a separate stream.

@nickstenning
Copy link
Contributor

LGTM, in that case.

@8W9aG 8W9aG merged commit 52c8768 into main Aug 23, 2024
15 checks passed
@8W9aG 8W9aG deleted the optimize-pyenv branch August 23, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0