Add strip to cog builds #1902
Add strip to cog builds #1902
Conversation
* Strip out all unnecessary debug symbols shipped by prebuilt shared objects. * Careful not to touch the cpython binaries they don’t like strip, but they can be handled separately with flags. * This speeds up load times of the shared objects, especially when it comes to PyTorch.
|
|
Yeh great idea I'll do it there |
* Do this so the entire operation happens in one layer of docker. * Include —-no-cache-dir as a way of preventing non-running related code from entering the docker
Signed-off-by: Will Sackfield <sackfield@replicate.com>
I do agree however a problem we face is that we need to build the base images as one shot, so some stuff needs to be done at the same time, and some stuff can be punted on. In terms of what we need to rebuild the base images: We can wait on: I can add a flag to disable the |
* Allow users to specify whether they want to strip the shared objects for a faster runtime.
Signed-off-by: Will Sackfield <sackfield@replicate.com>
separately with flags.