8000 Fix openapi schema by philandstuff · Pull Request #1947 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix openapi schema #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix openapi schema #1947

merged 1 commit into from
Sep 12, 2024

Conversation

philandstuff
Copy link
Contributor

Generating the OpenAPI schema was broken under the circumstances:

  • train.py#train had an enum-type input
  • cog was running with --x-mode=train

I've verified that this change fixes it. The current code is obviously wrong in any case.

Generating the OpenAPI schema was broken under the circumstances:

- train.py#train had an enum-type input
- cog was running with --x-mode=train

I've verified that this change fixes it.  The current code is obviously wrong in
any case.
@philandstuff philandstuff requested a review from a team September 12, 2024 12:09
Copy link
Contributor
@aron aron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor
@evilstreak evilstreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@philandstuff philandstuff merged commit 9d16cfc into main Sep 12, 2024
15 checks passed
@philandstuff philandstuff deleted the fix-openapi-schema branch September 12, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0