Prefix server errors with Cog:
#1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow for separation of error tracking. Connected to internal issue PLAT-265
nickstenning
reviewed
Oct 8, 2024
<
8000
div class="ml-md-2 mt-md-0 mt-2 flex-shrink-0">
View reviewed changes
There was a problem hiding this comment.
These error messages can and will be seen by users, so I think we should probably avoid the word "internal." Maybe just Cog:?
What do you think about using a custom user exception type rather than a constant? Something like:
class CogException(Exception):
def __str__(self):
return f"Cog: {super().__str__()}"If we did that I'd imagine stuff like UnknownPredictionError, RunnerBusyError, etc. all become subclasses of CogError.
The only slightly tricksy one is likely the TimeoutError for which we could probably get by with:
class CogTimeoutError(CogException, TimeoutError):
pass|
@nickstenning I would much prefer a custom exception class 🎉 |
cog-internal:Cog:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow for separation of error tracking.
Connected to internal issue PLAT-265