8000 他のパッケージをImportしている場合、エラーになる by devin-ai-integration[bot] · Pull Request #155 · rerost/giro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

他のパッケージをImportしている場合、エラーになる #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 29, 2025
Merged

他のパッケージをImportしている場合、エラーになる #155

merged 21 commits into from
Mar 29, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor
@devin-ai-integration devin-ai-integration bot commented Mar 29, 2025 •
edited by rerost
Loading

Add test using google/protobuf/empty.proto

This PR adds tests using google/protobuf/empty.proto as requested:

  1. Added EmptyCall method to TestService in e2etest/dummyserver/echo.proto
  2. Updated server implementation in runner.go to handle this method
  3. Added test cases for EmptyCall in test.ct
  4. Added GiroEmptyTest method to example service
  5. Updated GitHub workflow to test empty call

Link to Devin run: https://app.devin.ai/sessions/4dde8dc0263a48099bedc7344d8a5053
Requested by: Hazumi Ichijo

エラーの再現

rpc GiroEmptyTest(google.protobuf.Empty) returns (google.protobuf.Empty) {}

を追加すると

$ go run cmd/giro/main.go ls --reflection-server=localhost:5001 example.multiple_package.protos.one.GiroService
Error: proto: could not resolve import "google/protobuf/empty.proto": not found
Usage:
  giro ls [service|method] [flags]

Flags:
  -h, --help   help for ls

Global Flags:
      --debug
  -r, --reflection-server string    (default "localhost:5000")
      --rpc-server string
      --verbose

proto: could not resolve import "google/protobuf/empty.proto": not found
exit status 1

が発生

@devin-ai-integration @rerost
Add test using google/protobuf/empty.proto
c0f1543 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 3 commits March 29, 2025 05:25
@devin-ai-integration @rerost
Update Ruby server implementation for Empty proto test
ca7f33f 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Update Dockerfile to include protobuf dependencies
9848b8f 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Fix EmptyCall method to use emptypb.Empty
820f42c 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@codecov-commenter
Copy link
codecov-commenter commented Mar 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 173 lines in your changes missing coverage. Please review.

Project coverage is 3.87%. Comparing base (04aec8d) to head (005594b).

Files with missing lines Patch % Lines
domain/grpcreflectiface/client.go 0.00% 73 Missing ⚠️
e2etest/dummyserver/echo.pb.go 0.00% 30 Missing ⚠️
e2etest/dummyserver/echo_grpc.pb.go 0.00% 26 Missing ⚠️
example/multiple_package/protos/one/one_grpc.pb.go 0.00% 26 Missing ⚠️
e2etest/dummyserver/runner.go 0.00% 18 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #155      +/-   ##
=========================================
- Coverage    4.27%   3.87%   -0.40%     
=========================================
  Files          21      21              
  Lines        1662    1830     +168     
=========================================
  Hits           71      71              
- Misses       1585    1753     +168     
  Partials        6       6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

devin-ai-integration bot and others added 7 commits March 29, 2025 05:32
@devin-ai-integration @rerost
Regenerate protobuf files with emptypb.Empty
aafbcba 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Update Dockerfile to fix empty.proto import
a6bbefc 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Fix empty.proto creation in Dockerfile
6303b7d 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Fix protobuf imports: replace empty with emptypb
193e48b 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Add APP_PORT environment variable to Dockerfile
3d823ee 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Fix protobuf import paths to use github.com/golang/protobuf/ptypes/empty
75b42a1 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Update runner.go to use emptypb import
92ae1bd 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
rerost
rerost reviewed Mar 29, 2025
View reviewed changes
rerost/giro/hosts.pb.go Outdated
@@ -1,15 +1,15 @@
// Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.36.6
// protoc v5.29.4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

バージョンを変えないで

rerost
rerost reviewed Mar 29, 2025
View reviewed changes 8000
rerost/giro/hosts_grpc.pb.go Outdated
@@ -1,7 +1,7 @@
// Code generated by protoc-gen-go-grpc. DO NOT EDIT.
// versions:
// - protoc-gen-go-grpc v1.5.1
// - protoc v5.29.4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これもバージョン変えないで

devin-ai-integration bot and others added 10 commits March 29, 2025 05:51
@devin-ai-integration @rerost
Update to protoc v25.1 and fix emptypb imports
4887461 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Update protoc version to v5.29.4 in generated files
9fb8e49 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Fix empty.proto creation in Dockerfile
fa18904 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Update protoc installation in CI workflow
1bf3bf0 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@devin-ai-integration @rerost
Update generated protobuf files
4472c5e 
Co-Authored-By: Hazumi Ichijo <hahihu314+github@gmail.com>
@rerost
Revert version
9fb4f45
@rerost
Update protoc (#156)
cecb553 
Co-authored-by: bot <5201588+rerost@users.noreply.github.com>
@rerost
Remove creation of empty.proto file
eae7765
@rerost
probabilistically success
5c61336
@rerost
Fix
005594b
@rerost rerost changed the title Add test using google/protobuf/empty.proto 他のパッケージをImportしている場合、エラーになる Mar 29, 2025
@rerost rerost merged commit e33b96d into master Mar 29, 2025
7 checks passed
@rerost rerost deleted the devin/1743225701-add-empty-proto-test branch March 29, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerost rerost rerost left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecov-commenter @rerost
0