8000 fix: minecraft:air isn't empty in <1.11 by Loyisa · Pull Request #1220 · retrooper/packetevents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: minecraft:air isn't empty in <1.11 #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

fix: minecraft:air isn't empty in <1.11 #1220

merged 1 commit into from
May 14, 2025

Conversation

Loyisa
Copy link
Contributor
@Loyisa Loyisa commented May 6, 2025

Fixed a issue that make minecraft:air return isEmpty = false in 1.8
Close #1218
QQ20250506-181149

This PR also fixes the legacyData error condition of isEmpty (Short.MIN_VALUE in NMS) and wrong version condition in ItemStackSerialization.writeLegacy (that's not for 1.13 😭)

@iammehdib
Copy link

I'll add that in 1.8 when you open the inventory it crashes the client since the 28 April commit, I had to go back to the 18 April version to fix this problem, in 1.9 you see weird stone blocks in your inventory.image.png

@iammehdib
Copy link

How is it irrelevant? It's the 28 April commit that's the problem, the 30 March and 18 April commits have no problem, you mean that the automatic sterilisation of the air blocks weren't really air below 1.11? That's what I've been reporting and what you've apparently fixed.

@Loyisa
Copy link
Contributor Author
Loyisa commented May 7, 2025 •
edited
Loading

How is it irrelevant? It's the 28 April commit that's the problem, the 30 March and 18 April commits have no problem, you mean that the automatic sterilisation of the air blocks weren't really air below 1.11? That's what I've been reporting and what you've apparently fixed.

Sorry, I misread the commit that caused the problem 😭 (I thought it was the commit on Mar 30 that caused the problem)
it's caused by 4e4174b

@iammehdib
Copy link

How is it irrelevant? It's the 28 April commit that's the problem, the 30 March and 18 April commits have no problem, you mean that the automatic sterilisation of the air blocks weren't really air below 1.11? That's what I've been reporting and what you've apparently fixed.

Sorry, I misread the commit that caused the problem 😭 (I thought it was the commit on Mar 30 that caused the problem)
it's caused by 4e4174b

Ok but who to fix ?

@Loyisa
Copy link
Contributor Author
Loyisa commented May 14, 2025

How is it irrelevant? It's the 28 April commit that's the problem, the 30 March and 18 April commits have no problem, you mean that the automatic sterilisation of the air blocks weren't really air below 1.11? That's what I've been reporting and what you've apparently fixed.

Sorry, I misread the commit that caused the problem 😭 (I thought it was the commit on Mar 30 that caused the problem)
it's caused by 4e4174b

Ok but who to fix ?

I don't know why no one merged this PR :(

@retrooper retrooper merged commit ac4fac8 into retrooper:2.0 May 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.8 client kick on 1.8.8 server
3 participants
@Loyisa @iammehdib @retrooper
0