8000 feat: rate limit percentage by zolamk · Pull Request #1061 · reviewpad/reviewpad · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: rate limit percentage #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2023
Merged

feat: rate limit percentage #1061

merged 3 commits into from
Aug 24, 2023

Conversation

zolamk
Copy link
Contributor
@zolamk zolamk commented Aug 24, 2023 •
edited by reviewpad bot
Loading

Description

Add rate limit percentages to request logs

Summary generated by Reviewpad on 24 Aug 23 12:09 UTC

This pull request adds percentages to the request log. It introduces new fields "rate_limit_remaining_percentage" and "rate_limit_cost_percentage" to display the remaining and cost percentages respectively. Additionally, it refactors the code to use the remaining value to calculate the cost percentage. Lastly, it fixes an issue with the rounding of the percentages by adding a new "roundFloat" function.

🤖 Generated by Copilot at d09e1d0

Enhance GitHub client to log more rate limit information. Update tests in client_internal_test.go and add new fields to client.go for both REST and GraphQL APIs.

Code review and merge strategy

Ship: this pull request can be automatically merged and does not require code review

How

🤖 Generated by Copilot at d09e1d0

  • Add new fields to monitor rate limit usage of GitHub API client (link, link)
  • Update test cases for setRateLimitFields function (link, link)

@reviewpad reviewpad bot added ship Pull request can be automatically merged and does not require code review small small pull request labels Aug 24, 2023
reviewpad[bot]
reviewpad bot requested changes Aug 24, 2023
View reviewed changes
Copy link
@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checks are failing. Please fix them.

@reviewpad reviewpad bot added medium medium pull request and removed small small pull request labels Aug 24, 2023
@reviewpad reviewpad bot assigned < 8000 a data-hovercard-type="user" data-hovercard-url="/users/zolamk/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/zolamk">zolamk Aug 24, 2023
reviewpad[bot]
reviewpad bot approved these changes Aug 24, 2023
View reviewed changes
Copy link
@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is in ship mode. Reviewpad will merge it.

@reviewpad reviewpad bot added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 3a6f8f6 Aug 24, 2023
@ferreiratiago ferreiratiago deleted the feat/rate-limit-percentage branch August 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reviewpad reviewpad[bot] reviewpad[bot] approved these changes

Assignees

@zolamk zolamk

Labels
medium medium pull request ship Pull request can be automatically merged and does not require code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zolamk
0