8000 Release EXIT signal trap if SSH failed. by Myridium · Pull Request #85 · rien/reStream · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release EXIT signal trap if SSH failed. #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Release EXIT signal trap if SSH failed. #85

wants to merge 1 commit into from

Conversation

Myridium
Copy link

ssh access should not be attempted again if the reason the program is exiting is because ssh access failed.

I also think that the program should not print help messages to stdout when it is behaving under normal parameters. The error message received from ssh is self-explanatory.

@rien
Copy link
Owner
rien commented Dec 13, 2021

Hi @Myridium, thanks for your contribution. It is indeed a good idea to disable the ssh trap.

I would however like to keep the help messages. It may be better to forward them to stderr, but the script calls ssh with non-conventional settings which may confuse users (e.g. password authentication is disabled and in some cases EC-keys won't work). Not all users are familiar with ssh or scripting in general.

@Myridium
Copy link
Author

@rien that's okay, I agree. No need to make the script less accessible. Your code is written nicely so it's easy to remove if need be. Thanks for your work.

@rien
Copy link
Owner
rien commented Jan 9, 2024

This change is added in 3ad7c17

@rien rien closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Myridium @rien
0