8000 Added a few options to delete, update Solr docs and other options by hguillermo · Pull Request #3 · rishabhmhjn/helios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added a few options to delete, update Solr docs and other options #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2013
Merged

Added a few options to delete, update Solr docs and other options #3

merged 6 commits into from
Mar 20, 2013

Conversation

hguillermo
Copy link
Collaborator

Hi,

I made a lot of changes to use features included in Solr 4.x and up. These changes are:

  1. Added updateDoc method
  2. Added a deleteDoc method (a single doc or an array of ids to delete)
  3. Added a deleteDocByQuery (remove docs matching the query)
  4. Added a method to delete a doc field

In the addDoc readme you are using addField but I think it should be setField?

I tested my code and updated the README. Let me know if you need some other clarification.

Thanks,

Harry

@rishabhmhjn
Copy link
Owner

@hguillermo Thanks for the pull-request.

Somehow, GitHub is not allowing me to merge your commits into the repository and shows me the following.

This pull request cannot be automatically merged.

Maybe it is due to the changes that have been made in #2.
It will be great if you can merge that code into your repo and update this pull-request with your new merge commit.

@rishabhmhjn
Copy link
Owner

@hguillermo Never mind. I am doing the merging myself as I have to bump up the NPM version number to 0.0.4 too. Will update in a few minutes. Thanks again for the enhancements.

rishabhmhjn added a commit that referenced this pull request Mar 20, 2013
@rishabhmhjn
Merge remote-tracking branch 'remotes/hguillermo/master' into develop
bda0d4e 
Conflicts:
	lib/client.js

Merging for issue #3 and bumping the version to 0.0.4
@rishabhmhjn rishabhmhjn merged commit ac0a8b6 into rishabhmhjn:master Mar 20, 2013
@rishabhmhjn
Copy link
Owner

@hguillermo I have merged your code and updated the npm package helios also.
Thanks for these updates again. If you find anything wrong, please let me know.

@hguillermo
Copy link
Collaborator Author

Hi rishabhmhjn,

Thanks for that. I am working with this version to do changes in my stage Solr db and if I find something I will let you know. Thanks for the fast updates!

Harry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hguillermo @rishabhmhjn
0