10000 `IntervalUnit` cannot handle microseconds · Issue #4514 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

IntervalUnit cannot handle microseconds #4514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xiangjinwu opened this issue Aug 9, 2022 · 1 comment · Fixed by #8501
Closed

IntervalUnit cannot handle microseconds #4514

xiangjinwu opened this issue Aug 9, 2022 · 1 comment · Fixed by #8501
Assignees
@xiangjinwu
Labels
open to contribution Issues that are open to contribution. type/bug Type: Bug. Only for issues.
Milestone
release-0.18

Comments

@xiangjinwu
Copy link
Contributor

Describe the bug
In PostgreSQL, the interval type supports microsecond precision. However, our IntervalUnit implementation only stores milliseconds.

To Reproduce
Steps to reproduce the behavior.

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@xiangjinwu xiangjinwu added the type/bug Type: Bug. Only for issues. label Aug 9, 2022
@xiangjinwu xiangjinwu mentioned this issue Aug 9, 2022
Merged
3 tasks
@fuyufjh fuyufjh modified the milestone: release-0.1.13 Sep 5, 2022
@xiangjinwu xiangjinwu mentioned this issue Oct 10, 2022
Closed
@xiangjinwu
Copy link
Contributor Author

Maybe we can consolidate our IntervalUnit implementation with pg_interval::Interval, which is introduced by #5646

@xiangjinwu xiangjinwu mentioned this issue Nov 15, 2022
Merged
3 tasks
@BowenXiao1999 BowenXiao1999 mentioned this issue Dec 28, 2022
Closed
@TennyZhuang TennyZhuang added this to the release-0.1.18 milestone Feb 19, 2023
@TennyZhuang TennyZhuang added the good first issue Good for newcomers label Feb 20, 2023
@xiangjinwu xiangjinwu mentioned this issue Feb 22, 2023
Closed
@fuyufjh fuyufjh added the open to contribution Issues that are open to contribution. label Feb 27, 2023
@BugenZhao BugenZhao mentioned this issue Mar 6, 2023
Closed
This was referenced Mar 9, 2023
Closed
Merged
@xiangjinwu xiangjinwu self-assigned this Mar 9, 2023
@xiangjinwu xiangjinwu removed the good first issue Good for newcomers label Mar 9, 2023
@xiangjinwu xiangjinwu mentioned this issue Mar 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangjinwu xiangjinwu

Labels
open to contribution Issues that are open to contribution. type/bug Type: Bug. Only for issues.
Projects
None yet
Milestone
release-0.18
Development

Successfully merging a pull request may close this issue.

fix(common): interval should have microsecond precision risingwavelabs/risingwave
3 participants
@TennyZhuang @fuyufjh @xiangjinwu
0