feat(pgwire):support binary format param of timestampz and interval type #5646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8261b3d to
0b4d7cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #5646 +/- ##
==========================================
+ Coverage 74.85% 74.92% +0.06%
==========================================
Files 922 923 +1
Lines 146824 146932 +108
==========================================
+ Hits 109911 110083 +172
+ Misses 36913 36849 -64
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0b4d7cd to
ac038a6
Compare
There was a problem hiding this comment.
Most LGTM. @xiangjinwu PTAL.
- can add some e2e test or unit test?
- Timestampz -> Timestamptz, why?
xiangjinwu
approved these changes
Oct 17, 2022
| let instant = Utc.timestamp_nanos(elem * 1000); | ||
| let mut out = BytesMut::new(); | ||
| instant | ||
| .to_sql(&postgres_types::Type::ANY, &mut out) |
There was a problem hiding this comment.
Why not postgres_types::Type::TIMESTAMPTZ?
There was a problem hiding this comment.
Did you say &postgres_types::Type::ANY? This is only a placeholder. I will add a comment later.
There was a problem hiding this comment.
Yes> I am curious why we pass ANY here
There was a problem hiding this comment.
This place needs a reference of postgres_types::Type, I just pick one postgres_types::Type casually 😂
|
ac038a6 to
7569a3f
Compare
77bd895 to
d174491
Compare
d174491 to
dda22d2
Compare
dda22d2 to
7f5bc8c
Compare
BowenXiao1999
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#3676