8000 fix(streaming): two phase agg group key by kwannoel · Pull Request #7929 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(streaming): two phase agg group key #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Feb 27, 2023
Merged

fix(streaming): two phase agg group key #7929

merged 30 commits into from
Feb 27, 2023

Conversation

kwannoel
Copy link
Contributor
@kwannoel kwannoel commented Feb 14, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • Fix review comments.
  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL command 8000 s, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Feb 14, 2023
kwannoel
kwannoel commented Feb 14, 2023
View reviewed changes
kwannoel
kwannoel commented Feb 14, 2023
View reviewed changes
@kwannoel kwannoel force-pushed the fix-7928 branch 2 times, most recently from da81e8b to 9cc09bc Compare February 17, 2023 03:52
@kwannoel kwannoel marked this pull request as ready for review February 17, 2023 03:53
@kwannoel kwannoel marked this pull request as draft February 17, 2023 03:53
@kwannoel kwannoel force-pushed the fix-7928 branch 2 times, most recently from e02f984 to b6f1845 Compare February 24, 2023 07:39
@kwannoel kwannoel marked this pull request as ready for review February 24, 2023 12:54
This was referenced Feb 24, 2023
Closed
Open
@codecov
Copy link
codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #7929 (d1b8384) into main (001004f) will increase coverage by 0.00%.
The diff coverage is 98.34%.

@@           Coverage Diff           @@
##             main    #7929   +/-   ##
=======================================
  Coverage   71.70%   71.71%           
=======================================
  Files        1133     1133           
  Lines      182280   182324   +44     
=======================================
+ Hits       130705   130752   +47     
+ Misses      51575    51572    -3
Flag Coverage Δ
rust 71.71% <98.34%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/optimizer/plan_node/batch_hash_agg.rs 80.55% <95.23%> (-0.26%) ⬇️
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 98.17% <100.00%> (+0.12%) ⬆️
...rontend/src/optimizer/plan_node/stream_hash_agg.rs 97.08% <100.00%> (+0.08%) ⬆️
src/common/src/cache.rs 97.26% <0.00%> (+0.10%) ⬆️
...ontend/src/optimizer/plan_node/batch_hop_window.rs 70.76% <0.00%> (+4.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

st1page
st1page reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor
@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! rest LGTM.

st1page
st1page reviewed Feb 24, 2023
View reviewed changes
stdrc
stdrc approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member
@stdrc stdrc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM!

kwannoel and others added 2 commits February 25, 2023 00:20
@kwannoel kwannoel requested review from st1page and stdrc February 27, 2023 02:59
@lmatz lmatz added this pull request to the merge queue Feb 27, 2023
Merged via the queue into main with commit e9bc44b Feb 27, 2023
@lmatz lmatz deleted the fix-7928 branch February 27, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdrc stdrc stdrc approved these changes

@st1page st1page st1page approved these changes

@chenzl25 chenzl25 Awaiting requested review from chenzl25

Assignees
No one assigned
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: two phase stream agg panicked at Option::unwrap()
4 participants
@kwannoel @stdrc @st1page @lmatz
0