8000 perf(hash agg): use `get_mut` instead of `pop`+`put` pattern by stdrc · Pull Request #8691 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf(hash agg): use get_mut instead of pop+put pattern #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2023
Merged

perf(hash agg): use get_mut instead of pop+put pattern #8691

merged 3 commits into from
Mar 21, 2023

Conversation

stdrc
Copy link
Member
@stdrc stdrc commented Mar 21, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This fixes #8687. The safety concern was resolved in #7752 (comment).

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note
@stdrc
use get_mut instead of pop+put
57c3140 
Signed-off-by: Richard Chien <stdrc@outlook.com>
@github-actions github-actions bot added the type/perf Type: Performance. label Mar 21, 2023
@stdrc stdrc requested a review from TennyZhuang March 21, 2023 09:51
@stdrc
fix comment
f848ac5 
Signed-off-by: Richard Chien <stdrc@outlook.com>
@TennyZhuang TennyZhuang enabled auto-merge March 21, 2023 09:55
@stdrc
may be better
3fdc03a 
Signed-off-by: Richard Chien <stdrc@outlook.com>
@TennyZhuang TennyZhuang added this pull request to the merge queue Mar 21, 2023
@codecov
Copy link
codecov bot commented Mar 21, 2023 •
edited