8000 refactor(plan_node): simplify more structures by ice1000 · Pull Request #8898 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(plan_node): simplify more structures #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2023
Merged

refactor(plan_node): simplify more structures #8898

merged 6 commits into from
Mar 31, 2023

Conversation

ice1000
Copy link
Contributor
@ice1000 ice1000 commented Mar 30, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Deduplicate structures. This is a followup of #8870

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

@github-actions github-actions bot added type/refactor Type: Refactoring. user-facing-changes Contains changes that are visible to users labels Mar 30, 2023
@ice1000 ice1000 requested a review from st1page March 30, 2023 21:36
@ice1000 ice1000 removed the user-facing-changes Contains changes that are visible to users label Mar 30, 2023
@codecov
Copy link
8000
codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #8898 (5310c3f) into main (620ab91) will decrease coverage by 0.01%.
The diff coverage is 91.22%.

@@            Coverage Diff             @@
##             main    #8898      +/-   ##
==========================================
- Coverage   70.81%   70.80%   -0.01%     
==========================================
  Files        1181     1181              
  Lines      195771   195755      -16     
==========================================
- Hits       138628   138600      -28     
- Misses      57143    57155      +12
Flag Coverage Δ
rust 70.80% <91.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/optimizer/plan_node/batch_lookup_join.rs 62.50% <82.60%> (-0.18%) ⬇️
.../src/optimizer/plan_node/batch_nested_loop_join.rs 84.69% <85.71%> (-0.61%) ⬇️
...nd/src/optimizer/plan_node/stream_temporal_join.rs 64.41% <88.88%> (-1.27%) ⬇️
...rontend/src/optimizer/plan_node/batch_hash_join.rs 91.06% <100.00%> (ø)
...c/frontend/src/optimizer/plan_node/generic/join.rs 94.21% <100.00%> (+0.33%) ⬆️
...c/frontend/src/optimizer/plan_node/logical_join.rs 89.50% <100.00%> (-0.73%) ⬇️
...ntend/src/optimizer/plan_node/stream_delta_join.rs 96.38% <100.00%> (ø)
...ontend/src/optimizer/plan_node/stream_hash_join.rs 92.03% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ice1000
Copy link
Contributor Author
ice1000 commented Mar 30, 2023

We have muuuuuch less copies now!!

@ice1000 ice1000 added this pull request to the merge queue Mar 31, 2023
Merged via the queue into main with commit a36e013 Mar 31, 2023
@ice1000 ice1000 deleted the tesla/batch branch March 31, 2023 03:27
This was referenced Mar 31, 2023
Merged
Merged
Merged
Merged
This was referenced Apr 7, 2023
Merged
Merged
This was referenced Apr 15, 2023
Merged
Merged
Merged
This was referenced May 9, 2023
Merged
Merged
Merged
@ice1000 ice1000 mentioned this pull request May 18, 2023
Closed
1 task
This was referenced Jun 6, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st1page st1page st1page approved these changes

Assignees
No one assigned
Labels
type/refactor Type: Refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ice1000 @st1page
0