8000 refactor(test): split simulated integration tests into `scale` and `recovery` by BugenZhao · Pull Request #9369 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(test): split simulated integration tests into scale and recovery #9369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

BugenZhao
Copy link
Member
@BugenZhao BugenZhao commented Apr 23, 2023

Signed-off-by: Bugen Zhao i@bugenzhao.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In #7623, we've added some new recovery tests in CI for nexmark sources, which are put into the "scaling test" as it reuses the integration test framework of the scaling test.

This PR renames it into "simulation integration test" and then split it into two CI jobs: "scaling-test" and "recovery-integration-test". By doing this, we can parallel their executions and distinguish between their failures. Note that the build procedure is still singleton and all test cases will be archived into a single file.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…very

Signed-off-by: Bugen Zhao <i@bugenzhao.com>
@github-actions github-actions bot added the type/refactor Type: Refactoring. label Apr 23, 2023
@codecov
Copy link
codecov bot commented Apr 23, 2023

Codecov Report

Merging #9369 (05bae62) into main (2f62af4) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9369      +/-   ##
==========================================
- Coverage   70.79%   70.79%   -0.01%     
==========================================
  Files        1227     1227              
  Lines      203447   203447              
==========================================
- Hits       144039   144027      -12     
- Misses      59408    59420      +12     
Flag Coverage Δ
rust 70.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member
@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lick:

@BugenZhao BugenZhao added this pull request to the merge queue Apr 23, 2023
Merged via the queue into main with commit cd87630 Apr 23, 2023
@BugenZhao BugenZhao deleted the bz/reorg-simulation-its branch April 23, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor Type: Refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0