feat: support multiple temporal filter with or #14382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Jan 5, 2024
Comment on lines
-58
to
-61
| // We want to put `input_expr >/>= now_expr` before `input_expr </<= now_expr` as the former | ||
| // will introduce a watermark that can reduce state (since `now_expr` is monotonically | ||
| // increasing) | ||
| now_filters.sort_by_key(|l| rank_cmp(l.func_type())); |
There was a problem hiding this comment.
After #13985, we can do state cleaning for the temporal filter in any direct, So the order of the temporal filters is not important.
st1page
added a commit
that referenced
this pull request
Jan 5, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
split temporal filters into multiple filter plan node to support multiple temporal filter with or such as
(now_cond OR e1) AND (now_cond OR e2)Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.