8000 feat: support multiple temporal filter with or by st1page · Pull Request #14382 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support multiple temporal filter with or #14382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

st1page
Copy link
Contributor
@st1page st1page commented Jan 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

split temporal filters into multiple filter plan node to support multiple temporal filter with or such as (now_cond OR e1) AND (now_cond OR e2)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@st1page st1page requested a review from chenzl25 January 5, 2024 08:35
@github-actions github-actions bot added the type/feature Type: New feature. label Jan 5, 2024
Comment on lines -58 to -61
// We want to put `input_expr >/>= now_expr` before `input_expr </<= now_expr` as the former
// will introduce a watermark that can reduce state (since `now_expr` is monotonically
// increasing)
now_filters.sort_by_key(|l| rank_cmp(l.func_type()));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #13985, we can do state cleaning for the temporal filter in any direct, So the order of the temporal filters is not important.

Copy link
Contributor
@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@st1page st1page added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 7954da3 Jan 5, 2024
@st1page st1page deleted the sts/temporal_filter_or branch January 5, 2024 10:36
st1page added a commit that referenced this pull request Jan 5, 2024
Co-authored-by: stonepage <40830455+st1page@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Type: New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0