8000 chore(ci): revert changes specific to rustup v1.28 by kwannoel · Pull Request #20843 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(ci): revert changes specific to rustup v1.28 #20843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

chore(ci): revert changes specific to rustup v1.28 #20843

merged 1 commit into from
Mar 11, 2025

Conversation

kwannoel
Copy link
Contributor
@kwannoel kwannoel commented Mar 11, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After rustup v1.28.1, we no longer need any workaround. Fix #20728 (comment)

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@kwannoel kwannoel changed the title chore(ci): revert changes chore(ci): revert changes specific to rustup v1.28 Mar 11, 2025
@kwannoel kwannoel requested a review from xiangjinwu March 11, 2025 10:56
@kwannoel kwannoel enabled auto-merge March 11, 2025 11:57
@kwannoel kwannoel added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit f6faa2d Mar 11, 2025
47 of 48 checks passed
@kwannoel kwannoel deleted the kwannoel/revert- branch March 11, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

Assignees
No one assigned
Labels
type/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwannoel @xiangjinwu
0