8000 feat(storage): implement in memory FLAT vector index by wenym1 · Pull Request #21399 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(storage): implement in memory FLAT vector index #21399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

feat(storage): implement in memory FLAT vector index #21399

merged 1 commit into from
May 14, 2025
+682 −13

Conversation

wenym1
Copy link
Contributor
@wenym1 wenym1 commented Apr 14, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/feature Type: New feature. label Apr 14, 2025
This was referenced Apr 14, 2025
Merged
Merged
@wenym1 Graphite App
Copy link
Contributor Author
wenym1 commented Apr 14, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wenym1 wenym1 force-pushed the yiming/define-vector-read-write-trait branch from f7db8d8 to a046af3 Compare April 17, 2025 06:20
@wenym1 wenym1 force-pushed the yiming/in-memory-flat-vector-index branch from 0528339 to 146d3fc Compare April 17, 2025 06:20
hzxa21
hzxa21 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator
@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/storage/src/vector/mod.rs

pub fn add<'b>(
&mut self,
vecs: impl IntoIterator<Item = (VectorRef<'b>, &'b [u8])> + 'b,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elabrate more on what the &'b [u8] will be used? Is it for attaching some extra metadata/columns for the vector?

xxhZs
xxhZs reviewed Apr 25, 2025
View reviewed changes
@wenym1 wenym1 force-pushed the yiming/define-vector-read-write-trait branch from a046af3 to 2b690e5 Compare April 29, 2025 10:22
@wenym1 wenym1 force-pushed the yiming/in-memory-flat-vector-index branch from 8f614a0 to b3e9d11 Compare April 29, 2025 10:23
@wenym1 wenym1 mentioned this pull request Apr 29, 2025
Open
8 tasks
@wenym1 wenym1 force-pushed the yiming/define-vector-read-write-trait branch from 2b690e5 to 370226e Compare May 6, 2025 08:48
@wenym1 wenym1 force-pushed the yiming/in-memory-flat-vector-index branch 3 times, most recently from cc91de1 to 99acaeb Compare May 12, 2025 04:48
@wenym1 wenym1 force-pushed the yiming/define-vector-read-write-trait branch from 72f171d to 7842967 Compare May 12, 2025 05:47
@wenym1 wenym1 force-pushed the yiming/in-memory-flat-vector-index branch from 99acaeb to 624ac0d Compare May 12, 2025 05:47
@wenym1 wenym1 mentioned this pull request May 12, 2025
Open
8 tasks
Base automatically changed from yiming/define-vector-read-write-trait to main May 12, 2025 10:05
@wenym1 wenym1 force-pushed the yiming/in-memory-flat-vector-index branch from 624ac0d to 9301c64 Compare May 14, 2025 03:34
@wenym1 wenym1 added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit e2824e0 May 14, 2025
28 of 29 checks passed
@wenym1 wenym1 deleted the yiming/in-memory-flat-vector-index branch May 14, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxhZs xxhZs xxhZs left review comments

@hzxa21 hzxa21 hzxa21 approved these changes

Assignees
No one assigned
Labels
type/feature Type: New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenym1 @hzxa21 @xxhZs
0