fix: handle missing 'connector' field in WITH clause with CONNECTION #21691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and create sink statements
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error handling for missing connector fields in the WITH clause when a connection is used. It replaces unsafe unwrap calls with safe pattern matching in the create_source and create_sink handlers.
- Replaces unwrap() with a pattern matching block that returns a proper error for a missing connector.
- Uses distinct keys (UPSTREAM_SOURCE_KEY and CONNECTOR_TYPE_KEY) to provide context-specific error messages.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frontend/src/handler/create_source.rs | Uses pattern matching to safely obtain the connector and returns an error if absent. |
| src/frontend/src/handler/create_sink.rs | Applies similar safe extraction for connector and custom error messaging. |
Files not reviewed (1)
- e2e_test/source_inline/connection/ddl.slt: Language not supported
Comments suppressed due to low confidence (2)
src/frontend/src/handler/create_source.rs:932
- [nitpick] Verify that using UPSTREAM_SOURCE_KEY in the error message is the intended behavior for source creation, and consider ensuring consistent error code usage with similar handling in other modules.
let Some(connector) = with_properties.get_connector() else {
src/frontend/src/handler/create_sink.rs:140
- [nitpick] Double-check that the use of CONNECTOR_TYPE_KEY together with ErrorCode::ProtocolError is consistent with the codebase's error handling strategy and aligns with the intended semantics for sink creation.
let Some(connector) = resolved_with_options.get_connector() else {
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2025
…21691) Co-authored-by: tab <tabversion@bupt.icu>
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2025
…21691) Co-authored-by: tab <tabversion@bupt.icu>
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2025
…21691) Co-authored-by: tab <tabversion@bupt.icu>
|
✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
close #21650
The issue is spec to using with CONNECTION, as we will check the compatibility between CONNECTION type and SOURCE/SINK's connector. Not a framework level issue.
Checklist
Documentation
Release note