fix: print AlterSinkOperation::SetSinkProps correctly
#21790
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eses for changed properties
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the output formatting of AlterSinkOperation::SetSinkProps so that sink properties are printed using a comma-separated format. It also updates the corresponding test data to reflect the new output string.
- Replaced debug formatting with a call to display_comma_separated for sink properties.
- Updated the testdata YAML file to match the new printed output format.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/sqlparser/tests/testdata/alter.yaml | Updated formatted_sql to reflect the corrected output format for sink properties |
| src/sqlparser/src/ast/ddl.rs | Changed the formatter from debug printing to using display_comma_separated for better output control |
Comments suppressed due to low confidence (1)
src/sqlparser/src/ast/ddl.rs:481
- Consider verifying that display_comma_separated handles edge cases such as an empty changed_props list to ensure consistent formatting.
write!(f, "CONNECTOR WITH ({})", display_comma_separated(changed_props))
xxhZs
approved these changes
May 9, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
added 2 commits
May 9, 2025 14:29
…gwavelabs/risingwave into tab/fix-print-setsinkprops
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
Co-authored-by: tab <tabversion@bupt.icu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eses for changed properties
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
as title
introduced in #20691
What's changed and what's your intention?
Checklist
Documentation
Release note