8000 feat(foyer): add config field to set file cache fifo probation ratio by MrCroxx · Pull Request #21841 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(foyer): add config field to set file cache fifo probation ratio #21841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

feat(foyer): add config field to set file cache fifo probation ratio #21841

merged 1 commit into from
May 13, 2025

Conversation

MrCroxx
Copy link
Contributor
@MrCroxx MrCroxx commented May 13, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add config field to set file cache fifo probation ratio.

With ratio == 1.0, the behaviour is the same without the populated entry disk cache insertion optimization.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@MrCroxx
feat(foyer): add config field to set file cache fifo probation ratio
7c1e0c6 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx requested a review from Li0k May 13, 2025 06:43
@github-actions github-actions bot added the type/feature Type: New feature. label May 13, 2025
Li0k
Li0k approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@MrCroxx MrCroxx added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit bd177ef May 13, 2025
29 of 30 checks passed
@MrCroxx MrCroxx deleted the xx/probation branch May 13, 2025 07:18
MrCroxx added a commit that referenced this pull request May 13, 2025
@MrCroxx
feat(foyer): add config field to set file cache fifo probation ratio (#…
a730e2e 
…21841)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
MrCroxx added a commit that referenced this pull request May 22, 2025
@MrCroxx
feat(foyer): add config field to set file cache fifo probation ratio (#…
f5c8b1c 
…21841)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx mentioned this pull request May 22, 2025
Merged
8 tasks
MrCroxx added a commit that referenced this pull request May 22, 2025
@MrCroxx
feat(foyer): add config field to set file cache fifo probation ratio (#…
6117162 
…21841)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
MrCroxx added a commit that referenced this pull request May 22, 2025
@MrCroxx
Revert "feat(foyer): add config field to set file cache fifo probatio…
e32f435 
…n ratio (#21841)"

This reverts commit 6117162.
@MrCroxx MrCroxx mentioned this pull request May 22, 2025
Merged
8 tasks
MrCroxx added a commit that referenced this pull request May 22, 2025
@MrCroxx
feat(foyer): add config field to set file cache fifo probation ratio (#…
edbdd24 
…21841)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

Assignees
No one assigned
Labels
type/feature Type: New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrCroxx @Li0k
0