8000 fix(iceberg): fix delete file lost wake by xxchan · Pull Request #21848 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(iceberg): fix delete file lost wake #21848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

fix(iceberg): fix delete file lost wake #21848

merged 1 commit into from
May 14, 2025

Conversation

xxchan
Copy link
Member
@xxchan xxchan commented May 13, 2025 •
edited
Loading

When plan_task contains delete files, there's a probability that the scan will either return try_lock error, or block forever

fixed by risingwavelabs/iceberg-rust#48

Signed-off-by: xxchan xxchan22f@gmail.com

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@xxchan xxchan requested a review from a team as a code owner May 13, 2025 14:51
@xxchan xxchan requested a review from BugenZhao May 13, 2025 14:51
@github-actions github-actions bot added type/fix Type: Bug fix. Only for pull requests. ci/run-e2e-iceberg-tests labels May 13, 2025
@xxchan
.
fa1404a 
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan force-pushed the xxchan/legal-mastodon branch from 5747768 to fa1404a Compare May 13, 2025 14:56
@BugenZhao BugenZhao enabled auto-merge May 14, 2025 05:56
@BugenZhao BugenZhao added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit 358287b May 14, 2025
29 of 30 checks passed
@BugenZhao BugenZhao deleted the xxchan/legal-mastodon branch May 14, 2025 07:00
@github-actions github-actions bot mentioned this pull request May 14, 2025
Closed
github-actions bot pushed a commit that referenced this pull request May 14, 2025
@xxchan
fix(iceberg): fix delete file lost wake (#21848)
f459054 
Signed-off-by: xxchan <xxchan22f@gmail.com>
@github-actions github-actions bot mentioned this pull request May 14, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches.

github-merge-queue bot pushed a commit that referenced this pull request May 19, 2025
@github-actions @xxchan @cyliu0
fix(iceberg): fix delete file lost wake (#21848) (#21862)
824798c 
Signed-off-by: xxchan <xxchan22f@gmail.com>
Co-authored-by: xxchan <xxchan22f@gmail.com>
Co-authored-by: Chengyou Liu <35356271+cyliu0@users.noreply.github.com>
@xxchan xxchan mentioned this pull request May 21, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-iceberg-tests need-cherry-pick-since-release-2.3 type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

end-to-end iceberg test (release) timeout (stuck?)
2 participants
@xxchan @BugenZhao
0