feat(frontend): plan backfill order strategy after the planner phase, instead of binding phase #21813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2025
chenzl25
approved these changes
May 15, 2025
| @@ -35,7 +35,7 @@ use crate::session::SessionImpl; | |||
| /// We only bind tables, materialized views and sources. | |||
| /// Queries won't bind duplicate relations in the same query context. | |||
| /// But backfill order strategy can have duplicate relations. | |||
| pub fn bind_backfill_order_strategy( | |||
| pub fn plan_backfill_order_strategy( | |||
There was a problem hiding this comment.
Need to adjust the comments above?
There was a problem hiding this comment.
Will fix it in the downstream PR, otherwise leads to a lot of conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR is in preparation for #21814. To auto-derive backfill order, we need the stream plan, which is produced only after the planning phase.
So we do two things here:
We intentionally keep this PR separate from #21814, since we refactor file paths. To keep diffs clean, we should have the files in separate PRs.
Checklist
Documentation
Release note