fix(test): include uncovered streaming e2e tests #21827
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds uncovered streaming end-to-end tests for Nexmark sinks. It introduces new test sinks in two test files to improve coverage for streaming queries.
- Added a test sink for query q19 in nexmark_endless_part4.slt.
- Added a test sink for query q6_group_top1 in nexmark_endless_part2.slt.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| e2e_test/sink/nexmark_endless_sinks/nexmark_endless_part4.slt | Added test sink for streaming query q19 |
| e2e_test/sink/nexmark_endless_sinks/nexmark_endless_part2.slt | Added test sink for streaming query q6_group_top1 |
| @@ -3,6 +3,7 @@ include ../../nexmark/create_sources.slt.part | |||
| include ../../streaming/nexmark/sinks/q16.slt.part | |||
| include ../../streaming/nexmark/sinks/q17.slt.part | |||
| include ../../streaming/nexmark/sinks/q18.slt.part | |||
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment to describe the purpose and expected behavior of the new q19 test sink to aid future maintainers.
| include ../../streaming/nexmark/sinks/q18.slt.part | |
| include ../../streaming/nexmark/sinks/q18.slt.part | |
| -- The q19 test sink validates the behavior of the system for query 19 in the Nexmark benchmark. |
Copilot uses AI. Check for mistakes.
| @@ -2,6 +2,7 @@ include ../../nexmark/create_sources.slt.part | |||
|
|
|||
| include ../../streaming/nexmark/sinks/q4.slt.part | |||
| include ../../streaming/nexmark/sinks/q5.slt.part | |||
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment to clarify the testing scenario for the 'q6_group_top1' sink to improve readability and maintainability.
| include ../../streaming/nexmark/sinks/q5.slt.part | |
| include ../../streaming/nexmark/sinks/q5.slt.part | |
| -- Include the sink for testing the "group top 1" query (q6) in the Nexmark benchmark. |
Copilot uses AI. Check for mistakes.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close #21708.
Checklist
Documentation
Release note