8000 feat(iceberg): introduce per sink compaction config by Li0k · Pull Request #21837 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(iceberg): introduce per sink compaction config #21837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 16, 2025
Merged

feat(iceberg): introduce per sink compaction config #21837

merged 9 commits into from
May 16, 2025

Conversation

Li0k
Copy link
Contributor
@Li0k Li0k commented May 13, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  1. Introduce per sink compaction config
  • enable_compaction
  • compaction_interval
  1. Support validate config
  2. Update next_compaction_time based on compaction config

after #21824

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k changed the title feat(iceberg): introduce compaction config feat(iceberg): introduce per sink compaction config May 15, 2025
@Li0k Li0k requested review from chenzl25 and xxhZs May 15, 2025 06:23
@Li0k Li0k marked this pull request as ready for review May 15, 2025 06:23
chenzl25
chenzl25 approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor
@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

xxhZs
xxhZs reviewed May 15, 2025
View reviewed changes
@Li0k Li0k enabled auto-merge May 15, 2025 08:26
@Li0k Li0k added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@Li0k Li0k enabled auto-merge May 16, 2025 05:37
@Li0k Li0k added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 354c1ac May 16, 2025
32 of 33 checks passed
@Li0k Li0k deleted the li0k/iceberg_sink_config branch May 16 8A5B , 2025 06:10
kwannoel pushed a commit that referenced this pull request May 21, 2025
@Li0k @kwannoel
feat(iceberg): introduce per sink compaction config (#21837)
b9449e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxhZs xxhZs xxhZs left review comments

@chenzl25 chenzl25 chenzl25 approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-iceberg-tests ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/feature Type: New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Li0k @chenzl25 @xxhZs
0