8000 refactor(meta): Refactor some command structs to improve readability by Chiro11 · Pull Request #21992 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(meta): Refactor some command structs to improve readability #21992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

refactor(meta): Refactor some command structs to improve readability #21992

merged 1 commit into from
May 26, 2025
+74 −63

Conversation

Chiro11
Copy link
Contributor
@Chiro11 Chiro11 commented May 26, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@Chiro11 Chiro11 requested review from BugenZhao and wenym1 May 26, 2025 08:29
@Chiro11 Chiro11 marked this pull request as ready for review May 26, 2025 08:29
@Chiro11 Chiro11 mentioned this pull request May 26, 2025
Merged
8 tasks
BugenZhao
BugenZhao approved these changes May 26, 2025
View reviewed changes
Copy link
Member
@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Chiro11 Chiro11 enabled auto-merge May 26, 2025 08:51
@Chiro11 Chiro11 added this pull request to the merge queue May 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 26, 2025
@Chiro11 Chiro11 added this pull request to the merge queue May 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 26, 2025
@Chiro11
refactor(meta): Refactor some command structs to improve readability (#…
ac1b34b 
…21992)

Co-authored-by: Chiro11 <yxzhao2357@gmail.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 26, 2025
@Chiro11 Chiro11 added this pull request to the merge queue May 26, 2025
Merged via the queue into risingwavelabs:main with commit 3ea88e3 May 26, 2025
29 of 30 checks passed
@Chiro11 Chiro11 deleted the refactor/streaming_struct_name branch May 26, 2025 10:24
xxhZs pushed a commit that referenced this pull request May 29, 2025
@Chiro11 @xxhZs
refactor(meta): Refactor some command structs to improve readability (#…
f645420 
…21992)

Co-authored-by: Chiro11 <yxzhao2357@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

@wenym1 wenym1 wenym1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chiro11 @Li0k @BugenZhao @wenym1
0