fix: poll stream consumer for triggering callback func #21900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao-su
reviewed
May 17, 2025
Comment on lines
153
to
156
| // poll consumer to trigger callback functions | ||
| // We don't need to wait for the result, because recv may block and wait for next new message | ||
| let _ = tokio::time::timeout(Duration::from_millis(1000), consumer.recv()).await; | ||
|
|
There was a problem hiding this comment.
Will this read a new message and ignore it?
There was a problem hiding this comment.
after adjusting the code position, the recv call will not dismiss the first message.
There was a problem hiding this comment.
4d50e8d from #21868 also do the same change. already contained in image v2.2.6-patch-kafka-poll-log-level-3
hzxa21
reviewed
May 19, 2025
| @@ -100,6 +100,10 @@ impl SplitReader for KafkaSplitReader { | |||
| .await | |||
| .context("failed to create kafka consumer")?; | |||
|
|
|||
| // poll consumer to trigger callback functions | |||
| // We don't need to wait for the result, because recv may block and wait for next new message | |||
| let _ = tokio::time::timeout(Duration::from_millis(100), consumer.recv()).await; | |||
There was a problem hiding this comment.
Is it because we call recv before assign (in L155) that recv becomes a function purely for side-effect (trigger the callback) without fetching any message?
There was a problem hiding this comment.
Also, IIUC consumer.recv will be blocked indefinitely here. how do we make sure that the callback function must be triggered before the 100ms timeout?
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note