feat(iceberg): enable iceberg compaction for iceberg table and add license check #22043
+62
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe related to #21970 https://buildkite.com/risingwavelabs/pull-request/builds/75287#01971404-461c-4485-9db9-d89c3d1b1905 snowflake sink is not gated by the paywall. |
Li0k
approved these changes
May 29, 2025
| .is_ok() | ||
| .to_string(), | ||
| ); | ||
|
|
There was a problem hiding this comment.
add compaction_interval_sec, REST LGTM
Li0k
requested changes
May 29, 2025
| @@ -1714,6 +1714,14 @@ pub async fn create_iceberg_engine_table( | |||
|
|
|||
| sink_with.insert("is_exactly_once".to_owned(), "true".to_owned()); | |||
|
|
|||
| sink_with.insert( | |||
There was a problem hiding this comment.
check with_options.enable_compaction
…table_and_add_license_check
Li0k
reviewed
May 29, 2025
| @@ -1714,6 +1714,56 @@ pub async fn create_iceberg_engine_table( | |||
|
|
|||
| sink_with.insert("is_exactly_once".to_owned(), "true".to_owned()); | |||
|
|
|||
| if let Some(enable_compaction) = handler_args.with_options.get("enable_compaction") { | |||
There was a problem hiding this comment.
Here are two issues:
- This logic is implemented in a verbose way. We can encapsulate the logic for checking
enable_compactionwithinWithOptionsto reduce if branches. - When
enable_compaction == None, we don't need to check the license and should setenable_compaction=false.
There was a problem hiding this comment.
For iceberg engine, we should try our best to manage the table, so we should enable compaction if possible. Users only need to tune the config when they encounter performance issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note