8000 Limit recorded output to 32MB in size by bgentry · Pull Request #782 · riverqueue/river · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Limit recorded output to 32MB in size #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

bgentry
Copy link
Contributor
@bgentry bgentry commented Feb 20, 2025

It'd be a bad idea to get anywhere close to Postgres' jsonb limit of 255 MB. We choose 32MB as an arbitrary cap, though you really shouldn't get anywhere close to this.

@bgentry bgentry requested a review from brandur February 20, 2025 22:38
@bgentry bgentry force-pushed the bg-recorded-output-size-limit branch from 6d4cb38 to 057a8dd Compare February 20, 2025 22:38
Copy link
Contributor
@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah doh, sorry must've archived this one by accident. Too many issues/PRs flying around. LGTM.

@bgentry
Copy link
Contributor Author
bgentry commented Feb 22, 2025

@brandur np, I have been on a bit of a tear the last week or two 😄

@bgentry bgentry merged commit 6818f00 into master Feb 22, 2025
10 checks passed
@bgentry bgentry deleted the bg-recorded-output-size-limit branch February 22, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0