Implement job list with sqlc using templates #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
added a commit
that referenced
this pull request
Mar 8, 2025
…ting Here, fix an intermittent test [1] that's come up _already_ since #795 was merged in. This is a problem that gets me a lot, which is that map sorting in Go is not guaranteed, despite in tests small maps often coming out in the order that you're looking for so you don't notice a problem until later. Here, when processing named args in a template, walk through them in alphabetical order. This has no meaningful effect on the rendered SQL, but provides stability for the test suite. [1] https://github.com/riverqueue/river/actions/runs/13734150171/job/38415749775?pr=795
This was referenced Mar 8, 2025
bgentry
approved these changes
Mar 8, 2025
brandur
added a commit
that referenced
this pull request
Mar 9, 2025
…ting (#796) Here, fix an intermittent test [1] that's come up _already_ since #795 was merged in. This is a problem that gets me a lot, which is that map sorting in Go is not guaranteed, despite in tests small maps often coming out in the order that you're looking for so you don't notice a problem until later. Here, when processing named args in a template, walk through them in alphabetical order. This has no meaningful effect on the rendered SQL, but provides stability for the test suite. [1] https://github.com/riverqueue/river/actions/runs/13734150171/job/38415749775?pr=795
Here, reimplement the job list API's internals using sqlc using the new sqlc template system introduced in #794. Admittedly this one isn't quite as big of a win as we expect the templating to be in some cases, but it gets rid of a case of SQL code in a raw string, and lets us drop the `JobListFields` driver interface function. We don't add tests because the APIs are relatively well tested already, but make some small modifications to the driver `JobList` test cases so they're a little more thorough.
f7a8c28 to
1a4d0de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, reimplement the job list API's internals using sqlc using the new
sqlc template system introduced in #794. Admittedly this one isn't quite
as big of a win as we expect the templating to be in some cases, but it
gets rid of a case of SQL code in a raw string, and lets us drop the
JobListFieldsdriver interface function.We don't add tests because the APIs are relatively well tested already,
but make some small modifications to the driver
JobListtest cases sothey're a little more thorough.