8000 add JobList filters for ID and priority by bgentry · Pull Request #871 · riverqueue/river · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add JobList filters for ID and priority #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

Conversation

bgentry
Copy link
Contributor
@bgentry bgentry commented May 2, 2025

This allows more flexible filter options on JobList for ID and priority.

Before doing this, I had to get make tidy working by adding a couple of temporary replaces in cmd/river/go.mod. These must be removed before release.

@bgentry bgentry requested a review from brandur May 2, 2025 15:42
CHANGELOG.md Outdated
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added `JobInsertMiddlewareFunc` and `WorkerMiddlewareFunc` to easily implement middleware with a function instead of a struct. [PR #844](https://github.com/riverqueue/river/pull/844).
- Added `Config.Schema` which lets a non-default schema be injected explicitly into a River client that'll be used for all database operations. This may be particularly useful for proxies like PgBouncer that may not respect a schema configured in `search_path`. [PR #848](https://github.com/riverqueue/river/pull/848).
- Added `rivertype.HookWorkEnd` hook interface that runs after a job has been worked. [PR #863](https://github.com/riverqueue/river/pull/863).
- Added support for filtering jobs by a list of job IDs and by priorities in `JobList` and `JobListParams`. For more flexible job listing. [PR #XXX](https://github.com/riverqueue/river/pull/XXX).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added support for filtering jobs by a list of job IDs and by priorities in `JobList` and `JobListParams`. For more flexible job listing. [PR #XXX](https://github.com/riverqueue/river/pull/XXX).
- Added support for filtering jobs by a list of job IDs and by priorities in `JobList` and `JobListParams`. For more flexible job listing. [PR #871](https://github.com/riverqueue/river/pull/871).

@bgentry bgentry force-pushed the bg-more-job-filters branch from 1c37e48 to 83f5b8d Compare May 3, 2025 01:23
@bgentry bgentry enabled auto-merge (squash) May 3, 2025 01:23
@bgentry bgentry merged commit e30b067 into master May 3, 2025
10 checks passed
@bgentry bgentry deleted the bg-more-job-filters branch May 3, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0