Correct reindexer's handling of explicit schema #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, correct the reindexer's handling of an explicitly inject schema, which was being added with a "." _before_ the schema name instead of after. We also patch up the test suite. Looking into this, the error was being emitted in the tests as clear as day, but none of the tests were asserting anything (basically just that the reindexer ran in some way, shape, or form, not that it had been successful or done any work), so it was just being ignored. Fixes #915.
2636fcc to
a4c2c85
Compare
bgentry
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, correct the reindexer's handling of an explicitly inject schema,
which was being added with a "." before the schema name instead of
after.
We also patch up the test suite. Looking into this, the error was being
emitted in the tests as clear as day, but none of the tests were
asserting anything (basically just that the reindexer ran in some way,
shape, or form, not that it had been successful or done any work), so it
was just being ignored.
Fixes #915.