This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage0/{run,prepare}: remove ondisk verification #3623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Mar 27, 2017
rkt/image_verify.go
Outdated
| var ( | ||
| cmdImageVerify = &cobra.Command{ | ||
| Use: "verify IMAGE...", | ||
| Short: "Verify one or more images in the local store", |
There was a problem hiding this comment.
suggestion: "verify one or more rendered images"...
|
One thought: right now, whether or not an image is "rendered" is not really exposed to the user. It might make sense to skip or otherwise treat non-rendered images as not an error. |
|
@squeed Made that change, good call. In reality, unrendered images are fairly rare. |
|
The semaphore failure is a flake; the rest of the bots are happy |
For backwards compatibility, specifying 'insecure-options=ondisk' will still run without error, however it will also not do anything. Implements rkt#3481
This command replaces the previous ondisk verification that was done on every run. It can be used in cases where the user suspects their treestore has been corrupted in some way.
This avoids rendering an image that has not yet been rendered, and skips doing the verification for it since it's a nonsensical operation.
|
Rebased; fixed my imports to be |
|
This LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backwards compatibility, specifying 'insecure-options=ondisk' will
still run without error, however it will also not do anything.
Implements #3481
This also implements an
image verifysubcommand that provides the original ondisk verification functionality.This makes things much faster 💨 🚀.