8000 stage1/init/units: keep journald running while apps are shutting down by fabiokung · Pull Request #3726 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

stage1/init/units: keep journald running while apps are shutting down #3726

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

fabiokung
Copy link
Contributor

This prevents a race when apps are writing to their stdout/err (and
output is being sent to stage1's journal) while shutting down. If
journald terminates before the apps finish shutting down, their output
will be lost.

Signed-off-by: Fabio Kung fabio.kung@gmail.com

@ghost
Copy link
ghost commented Jun 22, 2017

Can one of the admins verify this patch?

@fabiokung fabiokung changed the title Keep journald running while apps are shutting down stage1/init/units: keep journald running while apps are shutting down Jun 22, 2017
This prevents a race when apps are writing to their stdout/err (and
output is being sent to stage1's journal) while shutting down. If
journald terminates before the apps finish shutting down, their output
will be lost.

Signed-off-by: Fabio Kung <fabio.kung@gmail.com>
Copy link
Member
@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0