api: add CreatedAt to v1.Pod #3797
Conversation
|
For reference, what's the CRI field this is forwarded to and what is its expected semantics? |
|
The CRI field is I think it matches better with rkt's creation time than start time. |
|
@iaguis agreed, it makes sense. If we already have some testing around status output can we at least introduce a check for the |
I can add an invariant check on the function that parses the output Then I can add a test that does |
|
@iaguis I'm personally happy enough with the first check and the always-positive check. |
It might happen that the pod is created but we can't get its start time (e.g. we can't find the CNI network corresponding to `--net=NETWORK`). This means StartedAt will not be set and the kubelet will error out and ignore the pod, so it won't try to start it again. Let's introduce CreatedAt to express the time when the pod was created (even if it doesn't start) to handle this. This works because this time is available after pod preparation. We'll need to change rktlet to use CreatedAt instead of StartedAt when getting a pod sandbox status.
1b8b66b to
bc2d912
Compare
|
Updated. |
It might happen that the pod is created but we can't get its start time
(e.g. we can't find the CNI network corresponding to
--net=NETWORK).This means StartedAt will not be set and the kubelet will error out and
ignore the pod, so it won't try to start it again.
Let's introduce CreatedAt to express the time when the pod was created
(even if it doesn't start) to handle this. This works because this time
is available after pod preparation.
We'll need to change rktlet to use CreatedAt instead of StartedAt when
getting a pod sandbox status.