8000 Update for React Native 0.78+ Compatibility: Enforce Stricter Kotlin Checks & Migrate to setViewTreeLifecycleOwner API V2 by mfazekas · Pull Request #3855 · rnmapbox/maps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update for React Native 0.78+ Compatibility: Enforce Stricter Kotlin Checks & Migrate to setViewTreeLifecycleOwner API V2 #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 26, 2025
Merged

Update for React Native 0.78+ Compatibility: Enforce Stricter Kotlin Checks & Migrate to setViewTreeLifecycleOwner API V2 #3855

merged 19 commits into from
May 26, 2025

Conversation

mfazekas
Copy link
Contributor
@mfazekas mfazekas commented May 22, 2025 •
edited
Loading

Description

To test you can add this to package.json

"@rnmapbox/maps": "rnmapbox/maps#Magnus-V-main"

See: #3844
Closes: #3844

ShahilMangroliya and others added 15 commits March 28, 2025 17:06
@ShahilMangroliya
fix(android): add null safety checks in various components to prevent…
3b700ac 
… potential crashes
@ShahilMangroliya
fix(android): set view tree lifecycle owner in RNMBXMapView to fix li…
5956963 
…fecycle management
@ShahilMangroliya
fix(android): enhance null safety checks in image and style component…
5cf6d01 
…s to improve error logging
@ShahilMangroliya
fix(android): add logger import to ChangeLineOffsetsShapeAnimatorModu…
41ed721 
…le for improved debugging
@ShahilMangroliya
fix(android): improve null value handling in ReadableArray and Readab…
fdc2a25 
…leMap with logging for better debugging
@Magnus-V
Added null handling in readableArray, added logging to RNMBXSHapeSour…
5b40438 
…ceManager and removed unused code
@Magnus-V
reverse setViewTreeLifecycleOwner changes and fix errors
0680f71
@Magnus-V
Merge remote-tracking branch 'new-upstream/main'
6cd1096
@Magnus-V
reinstate setViewTreeLifecycleOwner
ff4b037
@Magnus-V
update examples
7b8721b
@Magnus-V
Merge pull request #1 from Magnus-V/update-examples
cac1348 
update examples
@Magnus-V
Fix versions
4498a65
@Magnus-V
Updated, should work on iOS now
c90295f
@Magnus-V
Generate to fox old arch ran
13b91b2
@Magnus-V
updated to avoid mismatching dependencies to fix type-errors
fec58c5
@mfazekas
Copy link
Contributor Author
mfazekas commented May 23, 2025 •
edited
Loading

So this works fine on an Expo SDK 53 project, but won't work on Expo SDK 52. I'm looking into making it more compatible across versions.

To test you can add this to package.json

"@rnmapbox/maps": "rnmapbox/maps#Magnus-V-main"

@LDMFD
Copy link
LDMFD commented May 26, 2025 •
edited
Loading

This was briefly working for me last night but since this morning it's failing again:

> Could not resolve all dependencies for configuration ':app:debugRuntimeClasspath'.
   > Could not find com.mapbox.maps:android:10.18.4.
     Searched in the following locations:
       - file:/Users/darren/dev/p/ski/expo/node_modules/react-native/android/com/mapbox/maps/android/10.18.4/android-10.18.4.pom
       - https://dl.google.com/dl/android/maven2/com/mapbox/maps/android/10.18.4/android-10.18.4.pom
       - https://repo.maven.apache.org/maven2/com/mapbox/maps/android/10.18.4/android-10.18.4.pom
       - https://www.jitpack.io/com/mapbox/maps/android/10.18.4/android-10.18.4.pom
       - https://oss.sonatype.org/content/repositories/snapshots/com/mapbox/maps/android/10.18.4/android-10.18.4.pom
     Required by:
         project :app > project :rnmapbox_maps
   > Could not find com.mapbox.mapboxsdk:mapbox-sdk-turf:6.11.0.
     Searched in the following locations:
       - file:/Users/darren/dev/p/ski/expo/node_modules/react-native/android/com/mapbox/mapboxsdk/mapbox-sdk-turf/6.11.0/mapbox-sdk-turf-6.11.0.pom
       - https://dl.google.com/dl/android/maven2/com/mapbox/mapboxsdk/mapbox-sdk-turf/6.11.0/mapbox-sdk-turf-6.11.0.pom
       - https://repo.maven.apache.org/maven2/com/mapbox/mapboxsdk/mapbox-sdk-turf/6.11.0/mapbox-sdk-turf-6.11.0.pom
       - https://www.jitpack.io/com/mapbox/mapboxsdk/mapbox-sdk-turf/6.11.0/mapbox-sdk-turf-6.11.0.pom
       - https://oss.sonatype.org/content/repositories/snapshots/com/mapbox/mapboxsdk/mapbox-sdk-turf/6.11.0/mapbox-sdk-turf-6.11.0.pom
     Required by:
         project :app > project :rnmapbox_maps

Any ideas?

This is an Expo native app. o3 suggested (so don't blame me if it's way off) that Expo 53 bumps the tool-chain to React-Native 0.79 and Kotlin 2.0, whereas @rnmapbox/maps version 10.1.38 was built for Kotlin 1.9 and older. This branch fixes rnmapbox for Kotlin 2.0?

@mfazekas mfazekas merged commit bf7a2f0 into main May 26, 2025
11 checks passed
@mfazekas mfazekas deleted the Magnus-V-main branch May 26, 2025 03:49
@mfazekas mfazekas mentioned this pull request May 26, 2025
Closed
8 tasks
@efstathiosntonas efstathiosntonas mentioned this pull request Jun 11, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Magnus-V Magnus-V Magnus-V approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfazekas @LDMFD @Magnus-V @ShahilMangroliya
0