Vernactypes: combine In and Out infos and abstract use of state info #18421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many combinations did not make sense.
The abstraction
~~~ocaml
type ('a,'b,'x) runner = { run : 'd. 'x -> ('a -> 'b * 'd) -> 'x * 'd }
~~~
should hopefully make adding more independent states easier in the future.
670fe9a to
ee9efbb
Compare
ejgallego
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Looks pretty good to me @SkySkimmer
I'm taking the freedom to cc @gasche as he was kind to discuss with me about this problem, in case he'd like to have a look.
The idea of this patch is to help with the classification of Coq commands ("vernaculars"). We'd like to track what commands do to Coq's state, in terms of read / write, in a functional setting.
At some point we'd like to extend this system to track updates to parsing state, opaque proofs, etc...
|
🔴 CI failure at commit ee9efbb without any failure in the test-suite ✔️ Corresponding job for the base commit 078eaa3 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
|
CI problem seems unrelated. @coqbot: merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many combinations did not make sense.
The abstraction
should hopefully make adding more independent states easier in the future.