8000 Remove "env" argument of Evd.set_(l)eq_sort by SkySkimmer · Pull Request #20069 · rocq-prover/rocq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove "env" argument of Evd.set_(l)eq_sort #20069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove "env" argument of Evd.set_(l)eq_sort #20069

merged 1 commit into from
Jan 23, 2025

Conversation

SkySkimmer
Copy link
Contributor
@SkySkimmer SkySkimmer commented Jan 16, 2025 •
edited
Loading

@SkySkimmer SkySkimmer added kind: cleanup Code removal, deprecation, refactorings, etc. request: full CI Use this label when you want your next push to trigger a full CI. labels Jan 16, 2025
@SkySkimmer SkySkimmer requested review from a team as code owners January 16, 2025 15:31
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 16, 2025
@ppedrot
Copy link
Member
ppedrot commented Jan 16, 2025

Does it really hurt if we keep it around? We could realize at some point we need it for unrelated reasons. Functions that take env + sigma are a common design pattern in the code base.

@SkySkimmer
Copy link
Contributor Author

Taking useless arguments is a bad pattern.

@ppedrot ppedrot self-assigned this Jan 16, 2025
ppedrot
ppedrot approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member
@ppedrot ppedrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish.

@ppedrot ppedrot added the needs: overlay This is breaking external developments we track in CI. label Jan 16, 2025
SkySkimmer added a commit to SkySkimmer/MetaRocq that referenced this pull request Jan 22, 2025
@SkySkimmer
Adapt to rocq-prover/rocq#20069 (set_leq_sort doesn't need an env)
c407be4
SkySkimmer added a commit to SkySkimmer/unicoq that referenced this pull request Jan 22, 2025
@SkySkimmer
Adapt to rocq-prover/rocq#20069 (set_leq_sort doesn't need an env)
84a4849
SkySkimmer added a commit to SkySkimmer/Coq-Equations that referenced this pull request Jan 22, 2025
@SkySkimmer
Adapt to rocq-prover/rocq#20069 (set_leq_sort doesn't need an env)
4d4d3e5
@SkySkimmer SkySkimmer added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: overlay This is breaking external developments we track in CI. labels Jan 22, 2025
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 22, 2025
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Jan 22, 2025
@ppedrot ppedrot added this to the 9.1+rc1 milestone Jan 22, 2025
@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 22, 2025
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels Jan 22, 2025
@SkySkimmer
Remove "env" argument of Evd.set_(l)eq_sort
98b54ff 
It was only used to get type_in_type, but it's better to get it from
the ustate IMO.
@ppedrot
Copy link
Member
ppedrot commented Jan 23, 2025

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 7640e59 into rocq-prover:master Jan 23, 2025
6 checks passed
@coqbot-app coqbot-app
Copy link
Contributor
coqbot-app bot commented Jan 23, 2025

@ppedrot: Please take care of the following overlays:

  • 20069-SkySkimmer-set-leq-noenv.sh

ppedrot added a commit to MetaRocq/metarocq that referenced this pull request Jan 23, 2025
@ppedrot
Merge pull request #1136 from SkySkimmer/set-leq-noenv
9b27f1e 
Adapt to rocq-prover/rocq#20069 (set_leq_sort doesn't need an env)
ppedrot added a commit to mattam82/Coq-Equations that referenced this pull request Jan 23, 2025
@ppedrot
Merge pull request #630 from SkySkimmer/set-leq-noenv
eb85124 
Adapt to rocq-prover/rocq#20069 (set_leq_sort doesn't need an env)
@SkySkimmer SkySkimmer deleted the set-leq-noenv branch January 23, 2025 09:12
Janno added a commit to unicoq/unicoq that referenced this pull request Jan 23, 2025
@Janno
Merge pull request #97 from SkySkimmer/set-leq-noenv
0980ef0 
Adapt to rocq-prover/rocq#20069 (set_leq_sort doesn't need an env)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppedrot ppedrot ppedrot approved these changes

Assignees

@ppedrot ppedrot

Labels
kind: cleanup Code removal, deprecation, refactorings, etc.
Projects
None yet
Milestone
9.1+rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@SkySkimmer @ppedrot
0