Fix wrong threading of cv_pb/pb in unification.ml #20652
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we shadow cv_pb instead of having the 2 names coexist? |
SkySkimmer
reviewed
May 19, 2025
| @@ -1194,7 +1194,7 @@ let rec unify_0_with_initial_metas (subst : subst0) conv_at_top env cv_pb flags | |||
| (* Fast path for projections. *) | |||
| | Proj (p1,_,c1), Proj (p2,_,c2) when Environ.QConstant.equal env | |||
| (Projection.constant p1) (Projection.constant p2) -> | |||
| (try unify_same_proj curenvnb cv_pb {opt with at_top = true} | |||
| (try unify_same_proj curenvnb pb {opt with at_top = true} | |||
8000
There was a problem hiding this comment.
this one seems like it should be constant CONV btw
|
the test suite is failing, not sure why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while debugging my new universes branch.
We could sometimes use
CUMULinstead ofCONV, e.g. while unifying arguments of applications. This could result in unsatisfiable constraints being sent to the kernel.Fixes / closes #????
TODO
make doc_gram_rsts.