Remove the hypnaming API from Evarutil. #20689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All callers where behaving as if it where RenameExistingBut, hence only the varset matters.
SkySkimmer
reviewed
May 28, 2025
| | RenameExistingBut of VarSet.t | ||
| | FailIfConflict | ||
| | ProgramNaming of VarSet.t | ||
| type naming_mode = VarSet.t |
There was a problem hiding this comment.
maybe keep the constructor? ie
Suggested change
| type naming_mode = VarSet.t | |
| type naming_mode = RenameExistingBut of VarSet.t |
There was a problem hiding this comment.
But its name is now completely misleading. I don't mind keeping a box somewhere but the inductive approach doesn't look right to me. Since we never pattern-match on this from the outside we could add it as abstract injections, but then I don't really see the added value compared to just VarSet.t.
There was a problem hiding this comment.
Why is it misleading?
Anyway transparent type aliases aren't great either, why even have it instead of using varset directly?
SkySkimmer
approved these changes
Jun 4, 2025
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All callers where behaving as if it were RenameExistingBut, hence only the varset matters.